linux-kernel - Re: Results of my work on memorystick subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8497.77981.qm@web37601.mail.mud.yahoo.com>
Date:	Thu, 14 Oct 2010 01:00:33 -0700 (PDT)
From:	Alex Dubov <oakad@...oo.com>
To:	Maxim Levitsky <maximlevitsky@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Results of my work on memorystick subsystem

> From: Maxim Levitsky <maximlevitsky@...il.com>
> 
> and patch #6 contines adds even more cleanups, and makes
> whole
> memctick subsystem look nice and clean.
> Many non obivous functions were removen.

Replacing functional state handlers with nasty 3-page long switches on
undiscriminated integer state variables does not count either "cleaner"
nor "more obvious" in my notebook.

This is a matter of personal preference, I suppose.

Yet, at the very least, you should define an appropriate enum and give
your states readable names.



      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/