linux-kernel - Re: [tip:timers/urgent] hrtimer: Preserve timer state in remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1010141530360.2655@localhost6.localdomain6>
Date:	Thu, 14 Oct 2010 15:34:43 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Peter Zijlstra <peterz@...radead.org>
cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	sqazi@...gle.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:timers/urgent] hrtimer: Preserve timer state in
 remove_hrtimer()

On Thu, 14 Oct 2010, Peter Zijlstra wrote:

> On Thu, 2010-10-14 at 11:34 +0000, tip-bot for Salman Qazi wrote:
> > The bug was introduced with commit ca109491f (hrtimer: removing all ur
> > callback modes) in 2.6.29 
> 
> Not actually sure about that,. afaict its due to unlocking the base lock
> over the callback, which comes from 2d44ae4d7 (hrtimer: clean up
> cpu->base locking tricks), and existed before that in the special case
> of the scheduler tick (for which this problem is very unlikely to have
> ever triggered because we simply don't call start on it when its
> running).

Yeah, I got confused on that :)

 
> Anyway, the patch does look good, so


     tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/