| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101014142701.GP10421@parisc-linux.org> Date: Thu, 14 Oct 2010 08:27:01 -0600 From: Matthew Wilcox <matthew@....cx> To: Borislav Petkov <bp@...64.org> Cc: Randy Dunlap <randy.dunlap@...cle.com>, Linus Torvalds <torvalds@...ux-foundation.org>, lkml <linux-kernel@...r.kernel.org>, Doug Thompson <dougthompson@...ssion.com>, akpm <akpm@...ux-foundation.org>, "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org> Subject: Re: [PATCH] bitops.h: Widen BIT macro to support 64-bit types On Thu, Oct 14, 2010 at 02:12:30PM +0200, Borislav Petkov wrote: > From: Matthew Wilcox <matthew@....cx> > Date: Thu, Oct 14, 2010 at 07:12:13AM -0400 > > > On Thu, Oct 14, 2010 at 12:58:55PM +0200, Borislav Petkov wrote: > > > #ifdef __KERNEL__ > > > -#define BIT(nr) (1UL << (nr)) > > > +#define BIT(nr) (U64_C(1) << (nr)) > > > > Why not just use 1ULL instead? > > Wanted to be __ASSEMBLY__ safe. Admirable, but the entire file is __ASSEMBLY__ unsafe at this point, so I don't see the point. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists