linux-kernel - Re: [PATCH v3 4/6] x86/PCI: allocate space from the end of a region, not the beginning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201010140839.55474.bjorn.helgaas@hp.com>
Date:	Thu, 14 Oct 2010 08:39:55 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Bob Picco <bpicco@...hat.com>,
	Brian Bloniarz <phunge0@...mail.com>,
	Charles Butterfield <charles.butterfield@...tcentury.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	linux-pci@...r.kernel.org,
	"Horst H. von Brand" <vonbrand@....utfsm.cl>,
	linux-kernel@...r.kernel.org, Stefan Becker <chemobejk@...il.com>,
	Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH v3 4/6] x86/PCI: allocate space from the end of a region, not the beginning

On Wednesday, October 13, 2010 03:27:58 pm H. Peter Anvin wrote:
> On 10/13/2010 09:15 AM, Bjorn Helgaas wrote:
> >  
> > +#define ALIGN_DOWN(x, a)	((x) & ~(a - 1))
> > -	resource_size_t start = res->start;
> > +	resource_size_t start = ALIGN_DOWN(res->end - size + 1, align);
> >  
> 
> Use round_down() here instead of inventing yet another macro?

Thanks!  I searched for something, but I missed round_down().

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/