linux-kernel - Re: [PATCH 1/3] drivers: misc: ad525x_dpot: Fix typo in spi write16 and write24 transfer counts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101014152049.9471e1e6.akpm@linux-foundation.org>
Date:	Thu, 14 Oct 2010 15:20:49 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	<michael.hennerich@...log.com>
Cc:	linux-kernel@...r.kernel.org, ddbua@...log.com, drivers@...log.com,
	mike.frysinger@...log.com, chrisv@...erswitching.com
Subject: Re: [PATCH 1/3] drivers: misc: ad525x_dpot: Fix typo in spi write16
 and write24 transfer counts

On Thu, 14 Oct 2010 10:59:46 +0200
<michael.hennerich@...log.com> wrote:

> From: Michael Hennerich <michael.hennerich@...log.com>
> 
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
> ---
>  drivers/misc/ad525x_dpot-spi.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/ad525x_dpot-spi.c b/drivers/misc/ad525x_dpot-spi.c
> index b8c6df9..6cfcb63 100644
> --- a/drivers/misc/ad525x_dpot-spi.c
> +++ b/drivers/misc/ad525x_dpot-spi.c
> @@ -53,13 +53,13 @@ static int write8(void *client, u8 val)
>  static int write16(void *client, u8 reg, u8 val)
>  {
>  	u8 data[2] = {reg, val};
> -	return spi_write(client, data, 1);
> +	return spi_write(client, data, 2);
>  }
>  
>  static int write24(void *client, u8 reg, u16 val)
>  {
>  	u8 data[3] = {reg, val >> 8, val};
> -	return spi_write(client, data, 1);
> +	return spi_write(client, data, 3);
>  }
>  
>  static int read8(void *client)

What are the runtime effects of this change?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/