linux-kernel - Re: [patch 2/2] vfs: relax count check in rw_verify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101014163047.d909ad5c.akpm@linux-foundation.org>
Date:	Thu, 14 Oct 2010 16:30:47 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Edward Shishkin <edward.shishkin@...il.com>
Cc:	linux-fsdevel@...r.kernel.org, Eric Sandeen <sandeen@...hat.com>,
	lmcilroy@...hat.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [patch 2/2] vfs: relax count check in rw_verify_area

On Wed, 13 Oct 2010 22:46:21 +0200
Edward Shishkin <edward.shishkin@...il.com> wrote:

> Increase count limit in rw_verify_area().
> 

OK, now this is a truly awful attempt to describe a patch.

afaict what the patch does is to change rw_verify_area() so that the
kernel now permits single reads and writes of up to 2^63 bytes on
64-bit systems.  Whereas it was previously limited to 2^31.  And the
patch also fixes up a couple of callsites which were assuming that
rw_verify_area() had that particular behaviour.

But that's just my guess, based on a quick read of the implementation. 
I didn't check how far this change penetrates.  Does it affect all
filesystems, for example?  If so were they all reviewed (or tested!)
for correctness?

And why was this patch written?  What motivated you?  What are the
user-visible effects?  Do manpages need updating?

I don't want to have to sit here scratching my head over the
implications and intent of *your* patch.  As at least a starting
point, you should be telling us, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/