linux-kernel - Re: [PATCH -next] tifm: fix kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101014043551.GA4760@void.printf.net>
Date:	Thu, 14 Oct 2010 05:35:51 +0100
From:	Chris Ball <cjb@...top.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, Alex Dubov <oakad@...oo.com>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] tifm: fix kconfig dependencies

Hi,

On Wed, Oct 13, 2010 at 06:07:29PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix kconfig dependency warning to satisfy dependencies:
> 
> warning: (MMC_TIFM_SD && MMC && EXPERIMENTAL && PCI || MEMSTICK_TIFM_MS && MEMSTICK && EXPERIMENTAL && PCI) selects TIFM_CORE which has unmet direct dependencies (MISC_DEVICES && EXPERIMENTAL && PCI)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  drivers/memstick/host/Kconfig |    1 +
>  drivers/mmc/host/Kconfig      |    1 +
>  2 files changed, 2 insertions(+)
> 
> --- linux-next-20101013.orig/drivers/memstick/host/Kconfig
> +++ linux-next-20101013/drivers/memstick/host/Kconfig
> @@ -7,6 +7,7 @@ comment "MemoryStick Host Controller Dri
>  config MEMSTICK_TIFM_MS
>  	tristate "TI Flash Media MemoryStick Interface support  (EXPERIMENTAL)"
>  	depends on EXPERIMENTAL && PCI
> +	select MISC_DEVICES
>  	select TIFM_CORE
>  	help
>  	  Say Y here if you want to be able to access MemoryStick cards with
> --- linux-next-20101013.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20101013/drivers/mmc/host/Kconfig
> @@ -277,6 +277,7 @@ config MMC_MXC
>  config MMC_TIFM_SD
>  	tristate "TI Flash Media MMC/SD Interface support  (EXPERIMENTAL)"
>  	depends on EXPERIMENTAL && PCI
> +	select MISC_DEVICES
>  	select TIFM_CORE
>  	help
>  	  Say Y here if you want to be able to access MMC/SD cards with

Acked-by: Chris Ball <cjb@...top.org>
for the mmc hunk.

Andrew, perhaps you should take this to keep the mmc/memstick trees
from modifying files outside of their namespace? (Or we could just
ask Randy to split up the patch; whatever is preferred.)

Thanks,

-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/