linux-kernel - Re: [PATCH 2/2] ieee1394: remove the old IEEE 1394 driver stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 15 Oct 2010 01:29:20 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ieee1394: remove the old IEEE 1394 driver stack

On Thu, 2010-10-14 at 09:46 +0200, Stefan Richter wrote:
> Maxim Levitsky wrote:
> > On Sun, 2010-10-10 at 00:12 +0200, Stefan Richter wrote:
> >> The drivers
> >>   - ohci1394 (controller driver)
> >>   - ieee1394 (core)
> >>   - dv1394, raw1394, video1394 (userspace ABI)
> >>   - eth1394, sbp2 (protocol drivers)
> >> are replaced by
> >>   - firewire-ohci (controller driver)
> >>   - firewire-core (core and userspace ABI)
> >>   - firewire-net, firewire-sbp2 (protocol drivers)
> >> which are more featureful, better performing, and more secure than the older
> >> drivers; all with a smaller and more modern code base.
> > But new stack doesn't have working networking support...
> 
> firewire-net did work for me to /some/ degree when I tested it last:  Transfer
> s via FTP or SCP command line clients was OK, even with huge files, but an
> attempt to use FTP via desktop file manager ended in kernel crash.
> 
> In contrast, eth1394 worked to /some/ other degree for me when I tested it
> last:  It never crashed, but it had irregular performance (due to DMA context
> program overflow, besides ieee1394's tlabel recycling in a wrong context) when
> paired with {Linux,Windows,OS X}/x86, whereas transfers from and to an OS
> X/PPC peer always failed due to data corruption.
Here transfers new stack <-> new stack fail at around 250 KB due to
corrupted packets. (tested via SFTP and GUI).

But anyway, I can't agree more with what you said.
So go ahead and remove the old stack.
But maybe you need to move the firewire-net driver to staging? It really
doesn't work at all, this way or around.
EXPEREMENTAL today doesn't mean much.


Best regards,
	Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/