linux-kernel - Re: [PATCH v2] pseries: don't override CONFIG_PPC_PSERIES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Oct 2010 20:54:46 -0500
From:	Linas Vepstas <linasvepstas@...il.com>
To:	Nishanth Aravamudan <nacc@...ibm.com>
Cc:	michael@...erman.id.au,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Brian King <brking@...ux.vnet.ibm.com>,
	Anton Blanchard <anton@...ba.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frans Pop <elendil@...net.nl>, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pseries: don't override CONFIG_PPC_PSERIES_DEBUG

On 14 October 2010 19:48, Nishanth Aravamudan <nacc@...ibm.com> wrote:
> eeh and pci_dlpar #undef DEBUG, but I think they were added before the
> ability to control this from Kconfig. It's really annoying to only get
> some of the debug messages from these files. Leave the lpar.c #undef
> alone as it produces so much output as to make the kernel unusable.
> Update the Kconfig text to indicate this particular quirk :)
>
> Signed-off-by: Nishanth Aravamudan <nacc@...ibm.com>

OK, ignore my last email.

Acked by: Linas Vepstas <linasvepstas@...il.com>


> --- a/arch/powerpc/platforms/pseries/Kconfig
> +++ b/arch/powerpc/platforms/pseries/Kconfig
> @@ -47,6 +47,12 @@ config LPARCFG
>  config PPC_PSERIES_DEBUG
>        depends on PPC_PSERIES && PPC_EARLY_DEBUG
>        bool "Enable extra debug logging in platforms/pseries"
> +        help
> +         Say Y here if you want the pseries core to produce a bunch of
> +         debug messages to the system log. Select this if you are having a
> +         problem with the pseries core and want to see more of what is
> +         going on. This does not enable debugging in lpar.c, which must
> +         be manually done due to its verbosity.
>        default y

Umm, I see "default y" and you are not changing this but ... default y
?? Really?

Also, I am guessing that the lpar spam is due only to a handful of printk's,
while most of the rest will be infrequent.  Just knock out the
high-frequency ones...

--linas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/