linux-kernel - Re: [PATCH v2.6.36-rc7] drm/ttm: use cancel_delayed_work_sync() in ttm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CB868B2.60407@vmware.com>
Date:	Fri, 15 Oct 2010 16:44:02 +0200
From:	Thomas Hellstrom <thellstrom@...are.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Dave Airlie <airlied@...hat.com>,
	Jerome Glisse <jglisse@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2.6.36-rc7] drm/ttm: use cancel_delayed_work_sync() in
 ttm_bo

On 10/15/2010 02:12 PM, Tejun Heo wrote:
> Make ttm_bo::ttm_bo_device_release call cancel_delayed_work_sync()
> instead of calling cancel_delayed_work() followed by
> flush_scheduled_work().
>
> This is to prepare for the deprecation and removal of
> flush_scheduled_work().
>
> Signed-off-by: Tejun Heo<tj@...nel.org>
>    
Acked-by: Thomas Hellstrom <thellstrom@...are.com>

Thanks,
Thomas


> ---
>   drivers/gpu/drm/ttm/ttm_bo.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: work/drivers/gpu/drm/ttm/ttm_bo.c
> ===================================================================
> --- work.orig/drivers/gpu/drm/ttm/ttm_bo.c
> +++ work/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1480,8 +1480,7 @@ int ttm_bo_device_release(struct ttm_bo_
>   	list_del(&bdev->device_list);
>   	mutex_unlock(&glob->device_list_mutex);
>
> -	if (!cancel_delayed_work(&bdev->wq))
> -		flush_scheduled_work();
> +	cancel_delayed_work_sync(&bdev->wq);
>
>   	while (ttm_bo_delayed_delete(bdev, true))
>   		;
>    

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/