linux-kernel - Re: [PATCH RFC] workqueue: remove in_workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CB869CC.7070800@kernel.org>
Date:	Fri, 15 Oct 2010 16:48:44 +0200
From:	Tejun Heo <tj@...nel.org>
To:	paulmck@...ux.vnet.ibm.com
CC:	lkml <linux-kernel@...r.kernel.org>, mst@...hat.com
Subject: Re: [PATCH RFC] workqueue: remove in_workqueue_context()

On 09/23/2010 07:10 PM, Paul E. McKenney wrote:
> On Thu, Sep 23, 2010 at 02:35:07PM +0200, Tejun Heo wrote:
>> Commit a25909a4 (lockdep: Add an in_workqueue_context() lockdep-based
>> test function) added in_workqueue_context() but there hasn't been any
>> in-kernel user and the lockdep annotation in workqueue is scheduled to
>> change.  Remove the unused function.
>>
>> Signed-off-by: Tejun Heo <tj@...nel.org>
>> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
>> ---
>> Paul, I was looking through lockdep annotations to see how they can be
>> improved and noticed that in_workqueue_context() isn't used by anyone
>> and it seems like there hasn't been any in-kernel user either.  Can
>> this be removed or do you expect to use it somewhere?
> 
> I added it for the drivers/vhost changes.  They were using a
> variant of RCU where executing in workqueue context acted as an RCU
> read-side critical section and where flushing workqueues acted as
> an RCU grace period.  The in_workqueue_context() was then passed to
> rcu_dereference_check() to verify correct usage.
> 
> But you are right, I don't see it being used any more, though I do still
> see the big block comment documenting this in drivers/vhost/vhost.h.
> 
> Michael, what are Tejun and I missing here?

Ping.  Shall I go forward with this patch?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/