[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <4CB86F94.7080702@kernel.org>
Date: Fri, 15 Oct 2010 17:13:24 +0200
From: Tejun Heo <tj@...nel.org>
To: lkml <linux-kernel@...r.kernel.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Rusty Russell <rusty@...tcorp.com.au>
Subject: [PATCH v2.6.36-rc7] init: don't call flush_scheduled_work() from
do_initcalls()
It's unclear what flush_scheduled_work() in do_initcalls() tries to
achieve. The call doesn't make much sense - there already are
multiple system workqueues which aren't affected by
flush_scheduled_wokr() and subsystems are free to create and use their
own. Ordering requirements are and should be expressed explicitly.
Drop the call to prepare for deprecation and removal of
flush_scheduled_work().
Signed-off-by: Tejun Heo <tj@...nel.org>
---
If no one objects, I'll route this through wq tree.
Thank you.
init/main.c | 3 ---
1 file changed, 3 deletions(-)
Index: work/init/main.c
===================================================================
--- work.orig/init/main.c
+++ work/init/main.c
@@ -778,9 +778,6 @@ static void __init do_initcalls(void)
for (fn = __early_initcall_end; fn < __initcall_end; fn++)
do_one_initcall(*fn);
-
- /* Make sure there is no pending stuff from the initcall sequence */
- flush_scheduled_work();
}
/*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists