[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTimFp8MhnWf+ztK5NRzVvAJ3Qbn2mU6WD-Wz4yGp@mail.gmail.com>
Date: Fri, 15 Oct 2010 09:20:27 -0700
From: Nikhil Rao <ncrao@...gle.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Ingo Molnar <mingo@...e.hu>, Mike Galbraith <efault@....de>,
Suresh Siddha <suresh.b.siddha@...el.com>,
Venkatesh Pallipadi <venki@...gle.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] sched: force balancing on newidle balance if local
group has capacity
On Fri, Oct 15, 2010 at 5:08 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Wed, 2010-10-13 at 12:09 -0700, Nikhil Rao wrote:
>> @@ -2824,6 +2845,10 @@ find_busiest_group(struct sched_domain *sd, int
>> this_cpu,
>> if (!sds.busiest || sds.busiest_nr_running == 0)
>> goto out_balanced;
>>
>> + /* SD_BALANCE_NEWIDLE trumps SMP nice when underutilized */
>> + if (idle == CPU_NEWLY_IDLE && check_utilization(&sds))
>> + goto force_balance;
>
>
> There's a large comment a few lines up from here that tries to explain
> all these funny reasons for not balancing, that wants updating too.
>
Will do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists