linux-kernel - Re: [PATCH 2.6.35-rc6] net-next: Add multiqueue support to vmxnet3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101015.092327.193701886.davem@davemloft.net>
Date:	Fri, 15 Oct 2010 09:23:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sbhatewara@...are.com
Cc:	bhutchings@...arflare.com, shemminger@...tta.com,
	netdev@...r.kernel.org, pv-drivers@...are.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.35-rc6] net-next: Add multiqueue support to vmxnet3
 driver

From: Shreyas Bhatewara <sbhatewara@...are.com>
Date: Thu, 14 Oct 2010 16:31:35 -0700

> Okay. It would be best to keep module parameters to dictate number
> of queues till ethtool commands to do so become available/easy to
> use (command to change number of tx queues do not exist).

No, because then you can never remove these knobs, they must stay
forever.

And also then every other driver developer can make the same
argument.  And then we have private knobs in every driver and
the user experience is a complete disaster.

Instead, the onus is on you to help get the ethtool interfaces
completed so your driver can provide the functionality it
wants.

Not the other way around (add crap first, use the proper interface
later whenever someone else gets around to it).

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/