linux-kernel - Re: [PATCH v2.6.36-rc7] mac80211: cancel restart_work explicitly instead of depending on flush_scheduled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CB883C9.6050104@kernel.org>
Date:	Fri, 15 Oct 2010 18:39:37 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Johannes Berg <johannes@...solutions.net>
CC:	Linux Wireless List <linux-wireless@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2.6.36-rc7] mac80211: cancel restart_work explicitly
 instead of depending on flush_scheduled_work()

Hello,

On 10/15/2010 06:21 PM, Johannes Berg wrote:
>> -        create_singlethread_workqueue(wiphy_name(local->hw.wiphy));
>> +        alloc_ordered_workqueue(wiphy_name(local->hw.wiphy), 0);
> 
> no description for this change?

Oops, right.  create_*workqueue() interfaces are being replaced by
alloc_*workqueue().  It's part of the workqueue interface update.

>> -    /*
>> -     * For key todo, it'll be empty by now but the work
>> -     * might still be scheduled.
>> -     */
>> -    flush_scheduled_work();
> 
> oops, todo work no longer exists...
> 
> Anyway, ACK.

Are you going to route this through wireless tree?  Shall I repost
with update patch description?

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/