linux-kernel - Re: [PATCH v2.6.36-rc7] input: cancel_delayed_work_sync() in hp680_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 15 Oct 2010 09:55:42 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Linux Input <linux-input@...r.kernel.org>,
	Jiri Slaby <jirislaby@...il.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2.6.36-rc7] input: cancel_delayed_work_sync() in
 hp680_ts_input

On Fri, Oct 15, 2010 at 02:16:09PM +0200, Tejun Heo wrote:
> Make hp680_ts_init/exit() call cancel_delayed_work_sync() instead of
> calling cancel_delayed_work() followed by flush_scheduled_work().
> 
> This is to prepare for the deprecation and removal of
> flush_scheduled_work().
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>

Applied, thanks Tejun.

> ---
>  drivers/input/touchscreen/hp680_ts_input.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> Index: work/drivers/input/touchscreen/hp680_ts_input.c
> ===================================================================
> --- work.orig/drivers/input/touchscreen/hp680_ts_input.c
> +++ work/drivers/input/touchscreen/hp680_ts_input.c
> @@ -107,8 +107,7 @@ static int __init hp680_ts_init(void)
>  	return 0;
> 
>   fail2:	free_irq(HP680_TS_IRQ, NULL);
> -	cancel_delayed_work(&work);
> -	flush_scheduled_work();
> +	cancel_delayed_work_sync(&work);
>   fail1:	input_free_device(hp680_ts_dev);
>  	return err;
>  }
> @@ -116,8 +115,7 @@ static int __init hp680_ts_init(void)
>  static void __exit hp680_ts_exit(void)
>  {
>  	free_irq(HP680_TS_IRQ, NULL);
> -	cancel_delayed_work(&work);
> -	flush_scheduled_work();
> +	cancel_delayed_work_sync(&work);
>  	input_unregister_device(hp680_ts_dev);
>  }
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/