linux-kernel - Re: [PATCH 2.6.35.4] irq: irq and pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101015125428.01120a8d@jbarnes-desktop>
Date:	Fri, 15 Oct 2010 12:54:28 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Seth Heasley <seth.heasley@...el.com>
Cc:	khali@...ux-fr.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg

On Mon, 4 Oct 2010 13:27:14 -0700
Seth Heasley <seth.heasley@...el.com> wrote:

> >> --- linux-2.6.35.4/drivers/i2c/busses/Kconfig.orig   2010-09-24
> >14:59:23.000000000 -0700
> >> +++ linux-2.6.35.4/drivers/i2c/busses/Kconfig        2010-09-24
> >14:59:42.000000000 -0700
> >> @@ -95,7 +95,7 @@
> >>          ESB2
> >>          ICH8
> >>          ICH9
> >> -        Tolapai
> >> +        EP80579
> >>          ICH10
> >>          3400/5 Series (PCH)
> >
> >How did this become "5_3400_SERIES" in the symbol names? Shouldn't it
> >be 3400_5_SERIES instead?
> 
> The approved branding in pci.ids is 5/3400 Series, so I wanted to reflect that here.  I've changed it in Kconfig as well as i2c-i801.c to be consistent.
> 
> >> --- linux-2.6.35.4/drivers/i2c/busses/i2c-i801.c.orig        2010-09-24
> >14:57:55.000000000 -0700
> >> +++ linux-2.6.35.4/drivers/i2c/busses/i2c-i801.c     2010-09-24
> >14:59:13.000000000 -0700
> >> @@ -38,7 +38,7 @@
> >>    82801G   (ICH7)       0x27da     32     hard     yes     yes
> >yes
> >>    82801H   (ICH8)       0x283e     32     hard     yes     yes
> >yes
> >>    82801I   (ICH9)       0x2930     32     hard     yes     yes
> >yes
> >> -  Tolapai               0x5032     32     hard     yes     yes
> >yes
> >> +  EP80579               0x5032     32     hard     yes     yes
> >yes
> >
> >Maybe keep "Tolapai" inside parentheses, as people may know the
> >platform by that name by now?
> 
> Agreed.  I've updated that in both places it's referenced.  Final (hopefully) patch below:
> 
> This patch updates the defines for Intel devices in include/linux/pci_ids.h, referenced in arch/x86/pci/irq.c and drivers/i2c/busses/i2c-i801.c, reflecting approved legal branding, and using fuller code-names for products under development.
>  
> Signed-off-by: Seth Heasley <seth.heasley@...el.com>

Applied this update, thanks.

Note that going forward I don't expect (or want!) patches to convert
the development names into marketing names.  We should just add new
stuff with the development names (before the product ships) and leave
them that way to avoid unnecessary churn.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/