lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20101015100359.7860028e@linux.lan.towertech.it>
Date:	Fri, 15 Oct 2010 10:03:59 +0200
From:	Alessandro Zummo <a.zummo@...ertech.it>
To:	achew@...dia.com
Cc:	jmayo@...dia.com, olof@...om.net, greg@...ah.com,
	mcuos.com@...il.com, linux-kernel@...r.kernel.org,
	linux-tegra@...r.kernel.org, rtc-linux@...glegroups.com,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 1/1 V2] rtc: Add real-time clock driver for Tegra.

On Thu, 14 Oct 2010 13:56:31 -0700
achew@...dia.com wrote:

> +	info->rtc_base = ioremap(res->start, res->end - res->start + 1);

 please use resource_size()


> +MODULE_DESCRIPTION("driver for Tegra internal RTC");
> +MODULE_LICENSE("GPL");

 missing MODULE_AUTHOR with email address

 pending those corrections,


 Acked-by: Alessandro Zummo <a.zummo@...ertech.it>


-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ