linux-kernel - Re: [PATCH v2.6.36-rc7 1/2] isdn/capi: unregister capictr notifier after init failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CB985BB.5080804@web.de>
Date:	Sat, 16 Oct 2010 13:00:11 +0200
From:	Jan Kiszka <jan.kiszka@....de>
To:	Tejun Heo <tj@...nel.org>
CC:	Karsten Keil <isdn@...ux-pingi.de>,
	Armin Schindler <mac@...ware.de>,
	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2.6.36-rc7 1/2] isdn/capi: unregister capictr notifier
 after init failure

Am 15.10.2010 14:42, Tejun Heo wrote:
> capidrv_init() could leave capictr notifier dangling after init
> failure.  Fix it.

Good catch!

I assume David will pick these two up for net-next. Adding him to CC.

Acked-by: Jan Kiszka <jan.kiszka@....de>

> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> ---
>  drivers/isdn/capi/capidrv.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: work/drivers/isdn/capi/capidrv.c
> ===================================================================
> --- work.orig/drivers/isdn/capi/capidrv.c
> +++ work/drivers/isdn/capi/capidrv.c
> @@ -2288,6 +2288,7 @@ static int __init capidrv_init(void)
> 
>  	errcode = capi20_get_profile(0, &profile);
>  	if (errcode != CAPI_NOERROR) {
> +		unregister_capictr_notifier(&capictr_nb);
>  		capi20_release(&global.ap);
>  		return -EIO;
>  	}



Download attachment "signature.asc" of type "application/pgp-signature" (260 bytes)