linux-kernel - Re: [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work() from diva_os_remove_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1010161441040.27329@justus.melware.de>
Date:	Sat, 16 Oct 2010 14:42:48 +0200 (CEST)
From:	Armin Schindler <armin@...ware.de>
To:	Tejun Heo <tj@...nel.org>
cc:	Karsten Keil <isdn@...ux-pingi.de>,
	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work()
 from diva_os_remove_soft_isr()

On Fri, 15 Oct 2010, Tejun Heo wrote:
> diva doesn't use workqueue and there is no reason to flush the system
> workqueue from diva_os_remove_soft_isr().  Remove it.
>
> This is to prepare for the deprecation and removal of
> flush_scheduled_work().

This is a leftover. Thanks.

Acked-by: Armin Schindler <armin@...ware.de>

> Signed-off-by: Tejun Heo <tj@...nel.org>
> ---
> drivers/isdn/hardware/eicon/divasmain.c |    2 --
> 1 file changed, 2 deletions(-)
>
> Index: work/drivers/isdn/hardware/eicon/divasmain.c
> ===================================================================
> --- work.orig/drivers/isdn/hardware/eicon/divasmain.c
> +++ work/drivers/isdn/hardware/eicon/divasmain.c
> @@ -15,7 +15,6 @@
> #include <asm/uaccess.h>
> #include <asm/io.h>
> #include <linux/ioport.h>
> -#include <linux/workqueue.h>
> #include <linux/pci.h>
> #include <linux/interrupt.h>
> #include <linux/list.h>
> @@ -546,7 +545,6 @@ void diva_os_remove_soft_isr(diva_os_sof
> 		void *mem;
>
> 		tasklet_kill(&pdpc->divas_task);
> -		flush_scheduled_work();
> 		mem = psoft_isr->object;
> 		psoft_isr->object = NULL;
> 		diva_os_free(0, mem);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/