linux-kernel - Re: [PATCH] kernel: trace: trace_kprobe.c: removed duplicated #include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 16 Oct 2010 15:11:54 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrea Gelmini <andrea.gelmini@...ma.net>
Cc:	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH] kernel: trace: trace_kprobe.c: removed duplicated
 #include


* Andrea Gelmini <andrea.gelmini@...ma.net> wrote:

> Removed linux/uaccess.h
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@...ma.net>
> ---
>  kernel/trace/trace_kprobe.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index 544301d..c5fb747 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -18,7 +18,6 @@
>   */
>  
>  #include <linux/module.h>
> -#include <linux/uaccess.h>
>  #include <linux/kprobes.h>
>  #include <linux/seq_file.h>
>  #include <linux/slab.h>
> @@ -479,7 +478,7 @@ struct probe_arg {
>  struct trace_probe {
>  	struct list_head	list;
>  	struct kretprobe	rp;	/* Use rp.kp for kprobe use */
> -	unsigned long 		nhit;
> +	unsigned long		nhit;
>  	unsigned int		flags;	/* For TP_FLAG_* */
>  	const char		*symbol;	/* symbol name */
>  	struct ftrace_event_class	class;

If you look at the actual code there's also other problems with the 
vertical spacing of this and other structures (fetch_param, fetch_type, 
trace_kprobe, etc.) defined here. Would be nice if you could check the 
whole file and fix those too.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/