linux-kernel - Re: [PATCH 02/05] Drivers: char: impi: Makefile: replace the use of <module>-objs with <module>-y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CB9DA37.6080504@gmail.com>
Date:	Sat, 16 Oct 2010 19:00:39 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Tracey Dent <tdent48227@...il.com>
CC:	gregkh@...e.de, alan@...rguk.ukuu.org.uk,
	akpm@...ux-foundation.org, mhw@...tsend.com, minyard@....org,
	openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/05] Drivers: char: impi: Makefile: replace the use
 of <module>-objs with <module>-y

On 10/16/2010 06:52 PM, Jiri Slaby wrote:
> On 10/16/2010 03:26 PM, Tracey Dent wrote:
>> Changed <module>-objs to <module>-y in Makefile.
>>
>> Signed-off-by: Tracey Dent <tdent48227@...il.com>
>> ---
>>  drivers/char/ipmi/Makefile |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile
>> index eb8a1a8..16a9364 100644
>> --- a/drivers/char/ipmi/Makefile
>> +++ b/drivers/char/ipmi/Makefile
>> @@ -2,7 +2,7 @@
>>  # Makefile for the ipmi drivers.
>>  #
>>  
>> -ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
>> +ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
> 
> NACK (and all of these). This will try to build 4 modules instead of
> one. Read Documentation/kbuild/makefiles.txt

Please disregard my NACK, I misread the patch.

regards,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/