linux-kernel - Re: [PATCH] ath9k: Convert to new PCI PM framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201010162202.52766.rjw@sisk.pl>
Date:	Sat, 16 Oct 2010 22:02:52 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Luis R. Rodriguez" <lrodriguez@...eros.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Linux-pm mailing list" <linux-pm@...ts.linux-foundation.org>,
	linux-wireless@...r.kernel.org, ath9k-devel@...ts.ath9k.org
Subject: Re: [PATCH] ath9k: Convert to new PCI PM framework

On Saturday, October 16, 2010, Luis R. Rodriguez wrote:
> On Fri, Oct 15, 2010 at 3:36 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> > From: Rafael J. Wysocki <rjw@...k.pl>
> >
> > The ath9k driver uses the legacy PCI power management (suspend
> > and resume) callbacks that apparently cause intermittent problems
> > to happen (the adapter sometimes doesn't resume correctly on my
> > Acer Ferrari One).  Make it use the new PCI PM and let the PCI core
> > code handle the PCI-specific details of power transitions.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> 
> Do you know when these hooks were added?

Well, which ones?  If you're asking about the new framework, it's been there
since 2.6.29 and is a recommended way of implementing PM hooks now.

Please have a look at Documentation/power/pci.txt. :-)

> If it fixes an issue should this go for stable?

I'm not 100% sure it fixes everything yet, although I hasn't been able to
reproduce the problem with it applied, so far.

So, I don't think it's -stable material at this point.  However, it should be
done anyway at one point, so it very well can be done right now, given that I
have the hardware to test it. :-)

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/