[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4CBA0C8C.6050909@s5r6.in-berlin.de>
Date: Sat, 16 Oct 2010 22:35:24 +0200
From: Stefan Richter <stefanr@...6.in-berlin.de>
To: Alan Stern <stern@...land.harvard.edu>
CC: David Brownell <david-b@...bell.net>,
USB list <linux-usb@...r.kernel.org>,
Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.36-rc7: NULL pointer dereference in ehci_clear_tt_buffer_complete
Alan Stern wrote:
> On Sat, 16 Oct 2010, Stefan Richter wrote:
>> Alan Stern wrote:
>>> --- usb-2.6.orig/drivers/usb/core/message.c
>>> +++ usb-2.6/drivers/usb/core/message.c
>>> @@ -323,8 +323,13 @@ static void sg_complete(struct urb *urb)
>>> /* on the last completion, signal usb_sg_wait() */
>>> io->bytes += urb->actual_length;
>>> io->count--;
>>> - if (!io->count)
>>> + if (!io->count) {
>>> + if (status == -ECONNRESET) {
>>> + printk(KERN_ERR "Delaying for test\n");
>>> + mdelay(600);
>>> + }
>>> complete(&io->complete);
>>> + }
>>>
>>> spin_unlock(&io->lock);
>>> }
>>>
>> I did so today on 2.6.36-rc8, without your other patch. I was still unable to
>> reproduce the bug. Forget the whole thing as unreproducible?
>
> What I said above wasn't quite right. This won't help trigger the
> oops, but it should trigger the line saying something like
>
> ehci_hcd 0000:00:12.2: qh ffff880208f07af0 (#00) state 5
>
> That's the real bug.
# grep ' qh ' /var/log/messages
Oct 11 22:29:21 stein kernel: ehci_hcd 0000:00:12.2: qh ffff880208f07af0 (#00)
state 5
I.e. there was none anymore since the one which I reported on Monday.
--
Stefan Richter
-=====-==-=- =-=- =----
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists