[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1287327110-9158-1-git-send-email-segooon@gmail.com>
Date: Sun, 17 Oct 2010 18:51:50 +0400
From: Vasiliy Kulikov <segooon@...il.com>
To: kernel-janitors@...r.kernel.org
Cc: Dan Williams <dan.j.williams@...el.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Linus Walleij <linus.walleij@...ricsson.com>,
linux-kernel@...r.kernel.org
Subject: [PATCH] dma: imx-dma: fix signedness bug
mxdmac->channel was unsigned, so check (imxdmac->channel < 0) for
failed imx_dma_request_by_prio() made no sence. Explicitly check
signed values.
Signed-off-by: Vasiliy Kulikov <segooon@...il.com>
---
drivers/dma/imx-dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index 346be62..75d870f 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -335,7 +335,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
imxdmac->imxdma_channel = imx_dma_request_by_prio("dmaengine",
DMA_PRIO_MEDIUM);
- if (imxdmac->channel < 0)
+ if ((int)imxdmac->channel < 0)
goto err_init;
imx_dma_setup_handlers(imxdmac->imxdma_channel,
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists