linux-kernel - Re: [PATCH 2/2] initramfs: Fix initramfs size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikCLHh5Uz-DRq9ws78We+SwCAqdurA6HfuJh-8Y@mail.gmail.com>
Date:	Sun, 17 Oct 2010 14:28:11 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>
Cc:	mmarek@...e.cz, Sam Ravnborg <sam@...nborg.org>,
	Michael Holzheu <holzheu@...ux.vnet.ibm.com>,
	tabbott@...lice.com, vda.linux@...glemail.com, hpa@...ux.intel.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	heiko.carstens@...ibm.com, schwidefsky@...ibm.com
Subject: Re: [PATCH 2/2] initramfs: Fix initramfs size calculation

On Tue, Aug 31, 2010 at 04:23, Hendrik Brueckner wrote:
> --- a/usr/initramfs_data.S
> +++ b/usr/initramfs_data.S
> @@ -28,4 +24,14 @@ SECTIONS
>  #include <linux/stringify.h>
>
>  .section .init.ramfs,"a"
> +__irf_start:
>  .incbin __stringify(INITRAMFS_IMAGE)
> +__irf_end:
> +.section .init.ramfs.info,"a"
> +.globl __initramfs_size
> +__initramfs_size:
> +#ifdef CONFIG_32BIT
> +       .long __irf_end - __irf_start
> +#else
> +       .quad __irf_end - __irf_start
> +#endif

i'm pretty sure this breaks on every symbol-prefixed arch.  at least,
it broke every Blackfin board:
init/built-in.o: In function `populate_rootfs':
init/initramfs.c:(.init.text+0x2548): undefined reference to `__initramfs_size'
init/initramfs.c:(.init.text+0x254e): undefined reference to `__initramfs_size'
make: *** [.tmp_vmlinux1] Error 1

look at VMLINUX_SYMBOL() in the vmlinux.lds.h file
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/