linux-kernel - Re: [PATCH] ad525x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101017121953.40831b35.rdunlap@xenotime.net>
Date:	Sun, 17 Oct 2010 12:19:53 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Mike Frysinger <vapier@...too.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	device-drivers-devel@...ckfin.uclinux.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linux-kernel@...r.kernel.org,
	Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH] ad525x_dpot: default to off

On Sun, 17 Oct 2010 02:22:25 -0400 Mike Frysinger wrote:

> From: Michael Hennerich <michael.hennerich@...log.com>
> 
> No reason for this to be enabled by default.

The default is automatically 'n', so please explain (more) why this is
needed...?

> 
> Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> ---
>  drivers/misc/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index b743312..7691f89 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -16,6 +16,7 @@ if MISC_DEVICES
>  config AD525X_DPOT
>  	tristate "Analog Devices Digital Potentiometers"
>  	depends on (I2C || SPI) && SYSFS
> +	default n
>  	help
>  	  If you say yes here, you get support for the Analog Devices
>  	  AD5258, AD5259, AD5251, AD5252, AD5253, AD5254, AD5255
> -- 

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/