linux-kernel - Re: [PATCH 2/3] fs/ceph/xattr.c: Use kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1010171436260.1842@cobra.newdream.net>
Date:	Sun, 17 Oct 2010 14:36:56 -0700 (PDT)
From:	Sage Weil <sage@...dream.net>
To:	Julia Lawall <julia@...u.dk>
cc:	Joe Perches <joe@...ches.com>, kernel-janitors@...r.kernel.org,
	ceph-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] fs/ceph/xattr.c: Use kmemdup

Thanks, applied!

sage


On Sun, 17 Oct 2010, Julia Lawall wrote:

> Convert a sequence of kmalloc and memcpy to use kmemdup.
> 
> The semantic patch that performs this transformation is:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression a,flag,len;
> expression arg,e1,e2;
> statement S;
> @@
> 
>   a =
> -  \(kmalloc\|kzalloc\)(len,flag)
> +  kmemdup(arg,len,flag)
>   <... when != a
>   if (a == NULL || ...) S
>   ...>
> - memcpy(a,arg,len+1);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
>  fs/ceph/xattr.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff -u -p a/fs/ceph/xattr.c b/fs/ceph/xattr.c
> --- a/fs/ceph/xattr.c
> +++ b/fs/ceph/xattr.c
> @@ -716,10 +716,9 @@ int ceph_setxattr(struct dentry *dentry,
>  
>  	/* preallocate memory for xattr name, value, index node */
>  	err = -ENOMEM;
> -	newname = kmalloc(name_len + 1, GFP_NOFS);
> +	newname = kmemdup(name, name_len + 1, GFP_NOFS);
>  	if (!newname)
>  		goto out;
> -	memcpy(newname, name, name_len + 1);
>  
>  	if (val_len) {
>  		newval = kmalloc(val_len + 1, GFP_NOFS);
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/