linux-kernel - Re: [PATCH 17/19] fs: Reduce inode I

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101017233921.GF29677@dastard>
Date:	Mon, 18 Oct 2010 10:39:21 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Nick Piggin <npiggin@...nel.dk>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor inode
 disposal

On Sun, Oct 17, 2010 at 06:05:19PM +1100, Nick Piggin wrote:
> On Sun, Oct 17, 2010 at 05:52:45PM +1100, Dave Chinner wrote:
> > > A really quick grep reveals cifs is using GlobalSMBSeslock inside i_lock
> > > too.
> > 
> > I'm having a grep-fail day. Where is that one?
> 
> Uh, inside one of the 6 places that i_lock is taken in cifs. The only
> non-trivial one, not surprisingly.

It's two function calls away from the use of i_lock, in a different file.
A quick grep on a warm, sunny Sunday afternoon between walking the
dog and heading down to the pub for a beer and dinner isn't going to
find that. :/

Anyway, this one looks fairly easy to fix as the code that locks
GlobalSMBSeslock is only called from this location. I'll code up a
patch to fix it.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/