linux-kernel - Re: [PATCH] checkpatch: allow single space before labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1287303678.20968.37.camel@Joe-Laptop>
Date:	Sun, 17 Oct 2010 01:21:18 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mike Frysinger <vapier@...too.org>
Cc:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: allow single space before labels

On Sun, 2010-10-17 at 04:05 -0400, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
>  # check for spaces at the beginning of a line.
> -		if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/)  {
> +		if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/ && $rawline !~ /:$/)  {

Perhaps that's not an ideal test.
Maybe "&& $rawline !~ /^\+ \w+:/" is better.

The current test misidentify labels with comments:
drivers/net/tulip/interrupt.c: oom:    /* Executed with RX ints disabled */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/