linux-kernel - Re: [PATCH] checkpatch: allow single space before labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin6H2AbL_Kr4XCtPOr+SQRxi0tKKF3puY4gybNu@mail.gmail.com>
Date:	Sun, 17 Oct 2010 06:30:03 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: allow single space before labels

On Sun, Oct 17, 2010 at 06:21, Peter Zijlstra wrote:
> On Sun, 2010-10-17 at 04:24 -0400, Mike Frysinger wrote:
>> feel free to extend however as long as the end result is no warnings
>> for " foo:" ;).
>
> I utterly detest those indented labels and am eradicating them wherever
> I notice them. There's really no sane reason to use them what so ever.
> Diff can be taught not to get confused about them, see my earlier email.

sure, with enough shell code thrown at a problem, you can do anything.
 the change that started these warnings was for an unrelated check.
no one proposed warning on indented labels, nor is there any statement
at all in the coding style on these.

considering you highlighted the biggest reason (diff by default does
not handle them properly), i think that invalidates against your "no
sane reason" statement.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/