linux-kernel - Re: [PATCH] of: xsysace: Fix OF probing on little-endian systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101018155052.GM19399@angua.secretlab.ca>
Date:	Mon, 18 Oct 2010 09:50:52 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Michal Simek <monstr@...str.eu>
Cc:	linux-kernel@...r.kernel.org, jaxboe@...ionio.com,
	hch@...radead.org, smaclennan@...atech.com,
	michal.simek@...alogix.com, john.williams@...alogix.com
Subject: Re: [PATCH] of: xsysace: Fix OF probing on little-endian systems

On Mon, Oct 18, 2010 at 03:33:09PM +1000, Michal Simek wrote:
> Convert big-endian DTB to little-endian if necessary.
> 
> Signed-off-by: Michal Simek <monstr@...str.eu>

Applied, thanks.

g.

> ---
>  drivers/block/xsysace.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
> index 057413b..66911d3 100644
> --- a/drivers/block/xsysace.c
> +++ b/drivers/block/xsysace.c
> @@ -1224,7 +1224,8 @@ ace_of_probe(struct platform_device *op, const struct of_device_id *match)
>  		bus_width = ACE_BUS_WIDTH_8;
>  
>  	/* Call the bus-independant setup code */
> -	return ace_alloc(&op->dev, id ? *id : 0, physaddr, irq, bus_width);
> +	return ace_alloc(&op->dev, id ? be32_to_cpup(id) : 0,
> +						physaddr, irq, bus_width);
>  }
>  
>  static int __devexit ace_of_remove(struct platform_device *op)
> -- 
> 1.6.4.182.g9ebfd
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/