linux-kernel - Re: [PATCH 1/1] um: fix global timer issue when using CONFIG_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Oct 2010 21:58:53 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Richard Weinberger <richard@....at>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, jdike@...toit.com,
	user-mode-linux-devel@...ts.sourceforge.net, arjan@...ux.intel.com,
	peterz@...radead.org
Subject: Re: [PATCH 1/1] um: fix global timer issue when using CONFIG_NO_HZ

On Sun, Oct 17, 2010 at 10:23 PM, Pekka Enberg <penberg@...helsinki.fi> wrote:
> On 16.10.2010 18.23, Richard Weinberger wrote:
>>
>> This fixes a issue which was introduced by fe2cc53e.
>> timeval_to_ns() returns long long and not int.
>> Due to that UML's timer did not work proper and caused timer freezes.
>>
>> LKML-Reference:<AANLkTik5_TCXeGzTWBZzE8F0Cb2bQq-D228xDXk87rhP () mail !
>> gmail ! com>
>> Signed-off-by: Richard Weinberger<richard@....at>
>> ---
>>  arch/um/os-Linux/time.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/um/os-Linux/time.c b/arch/um/os-Linux/time.c
>> index dec5678..6e3359d 100644
>> --- a/arch/um/os-Linux/time.c
>> +++ b/arch/um/os-Linux/time.c
>> @@ -60,7 +60,7 @@ static inline long long timeval_to_ns(const struct
>> timeval *tv)
>>  long long disable_timer(void)
>>  {
>>        struct itimerval time = ((struct itimerval) { { 0, 0 }, { 0, 0 }
>> });
>> -       int remain, max = UM_NSEC_PER_SEC / UM_HZ;
>> +       long long remain, max = UM_NSEC_PER_SEC / UM_HZ;
>>
>>        if (setitimer(ITIMER_VIRTUAL,&time,&time)<  0)
>>                printk(UM_KERN_ERR "disable_timer - setitimer failed, "
>
> Acked-by: Pekka Enberg <penberg@...nel.org>

Andrew, do you mind picking this patch up?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/