linux-kernel - Re: [PATCH 1/2] x86: Cleanup TIF value gaps in shift range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101018211028.GA5370@nowhere>
Date:	Mon, 18 Oct 2010 23:10:31 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>,
	David Rientjes <rientjes@...gle.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/2] x86: Cleanup TIF value gaps in shift range

On Mon, Oct 18, 2010 at 01:48:10PM -0700, H. Peter Anvin wrote:
> On 10/18/2010 01:35 PM, Frederic Weisbecker wrote:
> > 9, 19 and 26 values are missing from the TIF shift range, probably
> > due to flags that were removed by the past. Now repack the range
> > so that we can quickly retrieve the remaining free shift slots.
> > 
> > But take care of keeping the seperation between high and low bits
> > as some masks are created on top of this boundary.
> > 
> 
> What is the point of this?  All it seems is that it would make stupid
> debugging mistakes possible because someone looks at the values from the
> wrong kernel.
> 
> Feel free to put comments in:
> 
> /* 9 - unused - was TIF_xxx */
> 
> ... but I think gratuitous compaction is a really bad idea.
> 
> Nacked-by: H. Peter Anvin <hpa@...or.com>


I just felt the current state was messy. But I understand your reasons,
just forget those patches.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/