[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1287470061-4158-1-git-send-email-namhyung@gmail.com>
Date: Tue, 19 Oct 2010 15:34:21 +0900
From: Namhyung Kim <namhyung@...il.com>
To: Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>,
Andreas Dilger <adilger.kernel@...ger.ca>
Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] ext3: Check return value of sb_getblk()
Check return value of sb_getblk() is NULL. unlikely is addded here
since it is called from a loop and we've been OK without the check
until now.
Signed-off-by: Namhyung Kim <namhyung@...il.com>
---
fs/ext3/inode.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index ef1c23a..a7ac778 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -655,6 +655,12 @@ static int ext3_alloc_branch(handle_t *handle, struct inode *inode,
* parent to disk.
*/
bh = sb_getblk(inode->i_sb, new_blocks[n-1]);
+ if (unlikely(!bh)) {
+ n--;
+ err = -ENOMEM;
+ goto failed;
+ }
+
branch[n].bh = bh;
lock_buffer(bh);
BUFFER_TRACE(bh, "call get_create_access");
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists