linux-kernel - Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Oct 2010 08:44:02 +0100
From:	Ian Molton <ian@...menth.co.uk>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Magnus Damm <damm@...nsource.se>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function

I already acked it... wonder where it went?

Acked-by: Ian Molton <ian@...menth.co.uk>

:)

-- 
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/



2010/10/19 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>:
> Hello,
>
> On Tue, Mar 02, 2010 at 05:22:33PM +0100, Uwe Kleine-König wrote:
>> tc6393xb_mmc_resources (which was marked __devinitdata) is used in
>> tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
>> living in .text.  This is not save with CONFIG_HOTPLUG=n.
>>
>> This was introduced in
>>
>>       64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>> Cc: Ian Molton <ian@...menth.co.uk>
>> Cc: Magnus Damm <damm@...nsource.se>
>> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> ping
>
> Uwe
>> ---
>>  drivers/mfd/tc6393xb.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
>> index 4bc5a08..b057d8d 100644
>> --- a/drivers/mfd/tc6393xb.c
>> +++ b/drivers/mfd/tc6393xb.c
>> @@ -154,7 +154,7 @@ static struct resource __devinitdata tc6393xb_nand_resources[] = {
>>       },
>>  };
>>
>> -static struct resource __devinitdata tc6393xb_mmc_resources[] = {
>> +static struct resource tc6393xb_mmc_resources[] = {
>>       {
>>               .start  = 0x800,
>>               .end    = 0x9ff,
>> --
>> 1.7.0
>>
>>
>
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/