linux-kernel - Re: [PATCH 3/3] drivers: cleanup Kconfig stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Oct 2010 11:34:55 +0300
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	balbi@...com
Cc:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	linux-main <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH 3/3] drivers: cleanup Kconfig stuff

On Tue, Oct 19, 2010 at 11:18 AM, Felipe Balbi <balbi@...com> wrote:
> On Tue, Oct 19, 2010 at 03:04:26AM -0500, Felipe Contreras wrote:
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index db51ea1..523df52 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -156,6 +156,8 @@ config MENELAUS
>> config TWL4030_CORE
>>        bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
>>        depends on I2C=y && GENERIC_HARDIRQS
>> +       depends on ARCH_OMAP3 || ARCH_OMAP4
>
> It's just an i2c chip, not depending on OMAP will allow us for a much
> needed compile test on linux-next with different architectures.

Ok.

>> @@ -842,7 +840,8 @@ config USB_CDC_COMPOSITE
>>
>> config USB_G_NOKIA
>>        tristate "Nokia composite gadget"
>> -       depends on PHONET
>> +       depends on PHONET && MACH_NOKIA_RX51
>
> no. g_nokia only depends on PHONET, if someone else wants to use on
> another board, it's fine by me. Otherwise we will have to keep on adding
> more and more boards.

Ok.

>> +       depends on USB_GADGET_MUSB_HDRC
>
> this gadget also works on controllers other than musb. As long as they
> support enough endpoints and alternate settings, it should just work.
>
> It was fine as it was before. NAK

It's not fine. You can build with CONFIG_USB_G_NOKIA=y, and it doesn't
work. Definitely some dependency is missing.

>> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
>> index 20895c4..5484258 100644
>> --- a/drivers/usb/musb/Kconfig
>> +++ b/drivers/usb/musb/Kconfig
>> @@ -12,7 +12,7 @@ config USB_MUSB_HDRC
>>        depends on (USB || USB_GADGET)
>>        depends on (ARM || (BF54x && !BF544) || (BF52x && !BF522 &&
>> !BF523))
>>        select NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN)
>> -       select TWL4030_USB if MACH_OMAP_3430SDP
>> +       select TWL4030_USB if ARCH_OMAP3
>
> we have omap3-based boards which don't use twl4030-usb, they use
> nop-usb-xceiv. How do you want to handle that ?? NAK

How do you handle USB_MUSB_HDRC=y and NOP_USB_XCEIV=n and TWL4030_USB=n?

depends on (NOP_USB_XCEIV || TWL4030_USB) ?

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/