linux-kernel - Re: [PATCH] mfd/mc13xxx: don't open code kasprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101019105053.GM2736@sortiz-mobl>
Date:	Tue, 19 Oct 2010 12:50:54 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Vasiliy Kulikov <segooon@...il.com>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd/mc13xxx: don't open code kasprintf

Hi Uwe,

On Sun, Oct 10, 2010 at 09:39:46PM +0200, Uwe Kleine-König wrote:
> This fixes an off by one error noticed by Vasiliy Kulikov en passant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/mfd/mc13xxx-core.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
> index 93258ad..b763b8c 100644
> --- a/drivers/mfd/mc13xxx-core.c
> +++ b/drivers/mfd/mc13xxx-core.c
> @@ -687,7 +687,6 @@ EXPORT_SYMBOL_GPL(mc13783_adc_do_conversion);
>  static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx,
>  		const char *format, void *pdata, size_t pdata_size)
>  {
> -	char buf[30];
>  	const char *name = mc13xxx_get_chipname(mc13xxx);
>  
>  	struct mfd_cell cell = {
> @@ -695,11 +694,7 @@ static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx,
>  		.data_size = pdata_size,
>  	};
>  
> -	/* there is no asnprintf in the kernel :-( */
> -	if (snprintf(buf, sizeof(buf), format, name) > sizeof(buf))
> -		return -E2BIG;
> -
> -	cell.name = kmemdup(buf, strlen(buf) + 1, GFP_KERNEL);
> +	cell.name = kasprintf(GFP_KERNEL, format, name);
I don't think you need to allocate a name pointer here.
cell.name = mc13xxx_get_chipname(mc13xxx); should be enough as
platform_device_alloc() will memcpy it into an allocated buffer.

Cheers,
Samuel.


>  	if (!cell.name)
>  		return -ENOMEM;
>  
> -- 
> 1.7.2.3
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/