linux-kernel - Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101019133344.GG11713@pengutronix.de>
Date:	Tue, 19 Oct 2010 15:33:44 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Ian Molton <ian@...menth.co.uk>,
	Magnus Damm <damm@...nsource.se>
Subject: Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init
	function

On Tue, Oct 19, 2010 at 03:22:29PM +0200, Samuel Ortiz wrote:
> On Tue, Oct 19, 2010 at 03:07:05PM +0200, Uwe Kleine-König wrote:
> > On Tue, Oct 19, 2010 at 12:31:31PM +0200, Samuel Ortiz wrote:
> > > Hi Uwe,
> > > 
> > > On Tue, Oct 19, 2010 at 09:19:51AM +0200, Uwe Kleine-König wrote:
> > > > Hello,
> > > > 
> > > > On Tue, Mar 02, 2010 at 05:22:33PM +0100, Uwe Kleine-König wrote:
> > > > > tc6393xb_mmc_resources (which was marked __devinitdata) is used in
> > > > > tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
> > > > > living in .text.  This is not save with CONFIG_HOTPLUG=n.
> > > > > 
> > > > > This was introduced in
> > > > > 
> > > > > 	64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
> > > > > 
> > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > > > > Cc: Ian Molton <ian@...menth.co.uk>
> > > > > Cc: Magnus Damm <damm@...nsource.se>
> > > > > Cc: Samuel Ortiz <sameo@...ux.intel.com>
> > > > ping
> > > This one slipped through...
> > > I just applied a similar patch from Marek Vasut, are you ok with that ?
> > Hmm, cannot find it, neither in next nor in your tree.
> I just pushed it now.
> See http://www.spinics.net/lists/arm-kernel/msg101220.html if you still can't
> get it.
the change is identical, so OK.  I would have written "This patch fixes
a section mismatch.", not "Also, this causes a section mismatch."

But I don't care much.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/