linux-kernel - Re: [PATCH] nfs: fix unchecked value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CBDA843.7030809@nokia.com>
Date:	Tue, 19 Oct 2010 18:16:35 +0400
From:	Roman Borisov <ext-roman.borisov@...ia.com>
To:	linux-kernel@...r.kernel.org
CC:	Andy Shevchenko <ext-andriy.shevchenko@...ia.com>,
	Trond.Myklebust@...app.com, linux-nfs@...r.kernel.org
Subject: Re: [PATCH] nfs: fix unchecked value

On 10/13/2010 04:54 PM, Roman Borisov wrote:
> Return value of "decode_attr_bitmap()" was not checked;
>
> Signed-off-by: Roman Borisov<ext-roman.borisov@...ia.com>
> ---
>   fs/nfs/nfs4xdr.c |    5 ++++-
>   1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
> index 6ea5c93..9e9cb40 100644
> --- a/fs/nfs/nfs4xdr.c
> +++ b/fs/nfs/nfs4xdr.c
> @@ -2676,7 +2676,10 @@ out_overflow:
>   static int decode_attr_supported(struct xdr_stream *xdr, uint32_t *bitmap, uint32_t *bitmask)
>   {
>   	if (likely(bitmap[0]&  FATTR4_WORD0_SUPPORTED_ATTRS)) {
> -		decode_attr_bitmap(xdr, bitmask);
> +		int ret;
> +		ret = decode_attr_bitmap(xdr, bitmask);
> +		if (unlikely(ret<  0))
> +			return ret;
>   		bitmap[0]&= ~FATTR4_WORD0_SUPPORTED_ATTRS;
>   	} else
>   		bitmask[0] = bitmask[1] = 0;

Reviewed-by: Andy Shevchenko <ext-andriy.shevchenko@...ia.com>

Hello,

could you please review the patch and send the comments if any

Thanks,
Roman Borisov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/