linux-kernel - Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ea089ac75d4d15d88698468eacb7fe3@secure211.sgcpanel.com>
Date:	Tue, 19 Oct 2010 10:05:33 -0500
From:	Felipe Balbi <me@...ipebalbi.com>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	<balbi@...com>, <linux-usb@...r.kernel.org>,
	linux-omap <linux-omap@...r.kernel.org>,
	linux-main <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

Hi,

(already at home so using personal email)

On Tue, 19 Oct 2010 17:32:07 +0300, Felipe Contreras
<felipe.contreras@...il.com> wrote:
> There are two parts, one part is to fix the Kconfigs, and another was
> to come up with a way to replace the horrible defconfigs. Part two is
> mostly fixed thanks to 'make savedefconfig', since the defconfigs are
> not so horrible any more, but part one is a continued effort.
> 
> For part two Linus had the idea to use Kconfigs instead of defconfigs,
> but they would mostly look very similar to the current ones generated
> by 'make savedefconfig'.
> 
> I don't know what makes you think Linus didn't want part one to be
> done. He wanted the Kconfig.rx51 to be human readable, and you are
> proposing that TWL4030_USB should be manually added there... I don't
> think TWL4030_USB says anything to human beings.

I don't read anywhere Linus saying we should clutter drivers/*/Kconfig
with defaults. I think you're inverting things, it's much better
to select TWL4030_USB when you enable MACH_OMAP_RX51 then default y
if MACH_OMAP_RX51.

> Yes, but how do you get rid of the defconfig while also having a
> working USB_G_NOKIA? Somehow a transceiver should be automatically
> selected.

and you do that selection when the board is enabled otherwise the
drivers Kconfig will be cluttered with default Y if blabla.

But like I said before, it's Greg's ball. Personally, I think
you're taking the wrong approach.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/