lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Oct 2010 10:48:10 -0500 From: Shirish Pargaonkar <shirishpargaonkar@...il.com> To: Jeff Layton <jlayton@...ba.org> Cc: Stephen Rothwell <sfr@...b.auug.org.au>, Steve French <smfrench@...il.com>, linux-cifs@...r.kernel.org, linux-next@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: linux-next: build warning after merge of the cifs tree On Tue, Oct 19, 2010 at 8:13 AM, Jeff Layton <jlayton@...ba.org> wrote: > On Tue, 19 Oct 2010 16:21:20 +1100 > Stephen Rothwell <sfr@...b.auug.org.au> wrote: > >> Hi Steve, >> >> On Fri, 24 Sep 2010 13:55:31 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote: >> > >> > After merging the irqflags tree, today's linux-next build (powerpc >> > ppc64_defconfig) produced this warning: >> > >> > fs/cifs/sess.c: In function 'CIFS_SessSetup': >> > fs/cifs/sess.c:595: warning: unused variable 'blob_len' >> > >> > Introduced by commit 15f6bdfb9914b0c41848f874719911ba053be931 ("cifs >> > NTLMv2/NTLMSSP ntlmv2 within ntlmssp autentication code"). >> > CONFIG_CIFS_UPCALL is not set in this build. >> >> I am still getting this ... >> > > Yep. Looks clearly broken. blob_len is also declared twice in that > function which is just plain wrong. What probably makes the most sense > is to make it a u16 and get rid of the second declaration lower in the > function. But, there's another semi-related problem here too... > > blob_len gets assigned the return value of build_ntlmssp_auth_blob. > That function however doesn't have any mechanism to pass back an > error, even though it calls setup_ntlmv2_rsp and that function can > return one. > > The whole house of cards needs a bit of rework I think... > > Shirish, since you're already doing work in this area, can you fix that > too? > > Thanks, > -- > Jeff Layton <jlayton@...ba.org> > Looking into it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists