[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20101019011125.GA3905@lst.de>
Date: Tue, 19 Oct 2010 03:11:25 +0200
From: Christoph Hellwig <hch@....de>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org,
jdike@...toit.com, user-mode-linux-devel@...ts.sourceforge.net,
viro@...iv.linux.org.uk, toralf.foerster@....de,
Christoph Hellwig <hch@....de>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/1] hostfs: fix UML crash
On Mon, Oct 18, 2010 at 01:02:08PM -0700, Andrew Morton wrote:
> > >
> > > Is there any reason for hostfs to be playing with the f_spare field at all?
No, there is no reason at all. do_statfs is only called by
hostfs_statfs, which is the hostfs implementation of ->statfs. zeroing
of the spare fields is done by common code (vfs_statfs_native).
Can you submit a patch to just remove the spare_out argument to do_statfs?
> 365b1818 added f_flags to `struct statfs' but didn't carry that over to
> `struct compat_statfs' and hence didn't copy f_flags over into
> compat_statfs. Deliberate, or oversight?
Oversight.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists