lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Oct 2010 10:11:58 -0600 From: Jonathan Corbet <corbet@....net> To: Kay Sievers <kay.sievers@...y.org> Cc: linux-kernel <linux-kernel@...r.kernel.org>, Greg KH <greg@...ah.com> Subject: Re: [PATCH] support polling of /proc/swaps > From: Kay Sievers <kay.sievers@...y.org> > Subject: support polling of /proc/swaps > > System management wants to subscribe to changes in swap > configuration. Make /proc/swaps pollable like /proc/mounts. Please forgive me...I'm probably undercaffeinated and even dumber than usual, but... Here we have this: > +static unsigned swaps_poll(struct file *file, poll_table *wait) > +{ > + struct proc_swaps *s = file->private_data; But here I see: > static int swaps_open(struct inode *inode, struct file *file) > { > - return seq_open(file, &swaps_op); > + struct proc_swaps *s; > + int ret; > + > + s = kmalloc(sizeof(struct proc_swaps), GFP_KERNEL); > + if (!s) > + return -ENOMEM; > + > + file->private_data = &s->seq; It sure looks to me like private_data is a struct seq_file pointer, not a struct proc_swaps pointer. What am I missing? Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists