linux-kernel - Re: [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() + flush_scheduled_work() -> cancel_delayed_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101019121319.16f06b76@corrin.poochiereds.net>
Date:	Tue, 19 Oct 2010 12:13:19 -0400
From:	Jeff Layton <jlayton@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Steve French <sfrench@...ba.org>, linux-cifs@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() +
 flush_scheduled_work() -> cancel_delayed_work_sync()

On Tue, 19 Oct 2010 17:55:54 +0200
Tejun Heo <tj@...nel.org> wrote:

> flush_scheduled_work() is going away.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> ---
>  fs/cifs/cifs_dfs_ref.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Index: work/fs/cifs/cifs_dfs_ref.c
> ===================================================================
> --- work.orig/fs/cifs/cifs_dfs_ref.c
> +++ work/fs/cifs/cifs_dfs_ref.c
> @@ -44,8 +44,7 @@ static void cifs_dfs_expire_automounts(s
>  void cifs_dfs_release_automount_timer(void)
>  {
>  	BUG_ON(!list_empty(&cifs_dfs_automount_list));
> -	cancel_delayed_work(&cifs_dfs_automount_task);
> -	flush_scheduled_work();
> +	cancel_delayed_work_sync(&cifs_dfs_automount_task);
>  }
> 
>  /**

Looks like a better way to do this anyhow.

Reviewed-by: Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/