linux-kernel - Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation error with -fstack-protector and -Werror

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=Ssz4WdMDXq-93GE9bPHoaQ8QyTSrWXDSCa7eH@mail.gmail.com>
Date:	Tue, 19 Oct 2010 03:06:41 +0300
From:	Brian Gitonga Marete <marete@...hnix.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation error with
 -fstack-protector and -Werror

On Tue, Oct 19, 2010 at 2:38 AM, Frederic Weisbecker <fweisbec@...il.com> wrote:
> On Tue, Oct 19, 2010 at 02:24:00AM +0300, Brian Gitonga Marete wrote:
>> The following patch fixes compilation of the perf user-space tools on,
>> for example, gcc version 4.3.3 (Ubuntu 4.3.3-5ubuntu4) . It should not
>> break anything else.
>
>
>
> Hi,
>
> What kind of warning have you encountered and why it fixes it?
> Can you describe that in your changelog?
>

Hello Frederic,

Some versions of gcc, e.g. gcc version 4.3.3 (Ubuntu 4.3.3-5ubuntu4), have
the (default) minimum size of buffers protected by `-fstack-protector' set
to 8. But in perf, there exist much smaller automatic buffers.

This in combination with the -fstack-protector-all, -Werror and
-Wstack-protector causes the compile to fail for such a compiler.

The error encountered with the above-mentioned compiler is:

gcc -o util/ui/util.o -c -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6
-D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Wformat-y2k -Wshadow
-Winit-self -Wpacked -Wredundant-decls -Wstack-protector
-Wstrict-aliasing=3 -Wswitch-default -Wswitch-enum -Wno-system-headers
-Wundef -Wvolatile-register-var -Wwrite-strings -Wbad-function-cast
-Wmissing-declarations -Wmissing-prototypes -Wnested-externs
-Wold-style-definition -Wstrict-prototypes
-Wdeclaration-after-statement  -fstack-protector-all
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iutil/include
-Iarch/x86/include -DLIBELF_NO_MMAP -I/usr/include/elfutils
-DDWARF_SUPPORT -I/usr/include/slang -DSHA1_HEADER='<openssl/sha.h>'
util/ui/util.c
cc1: warnings being treated as errors
util/ui/util.c: In function ‘ui__dialog_yesno’:
util/ui/util.c:110: error: not protecting function: no buffer at least
8 bytes long

Signed-off-by: Brian Gitonga Marete <marete@...hnix.com>
---
 tools/perf/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 1950e19..64eb2ea 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -288,7 +288,7 @@ endif
 -include feature-tests.mak

 ifeq ($(call try-cc,$(SOURCE_HELLO),-Werror -fstack-protector-all),y)
-	CFLAGS := $(CFLAGS) -fstack-protector-all
+	CFLAGS := $(CFLAGS) -fstack-protector-all --param ssp-buffer-size=1
 endif


-- 
1.6.0.4


-- 
Brian Gitonga Marete
Toshnix Systems
Tel: +254722151590
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/