linux-kernel - Re: [PATCH v2] i2c/mux: Driver for PCA9541 I2C Master Selector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101019203101.197d493d@endymion.delvare>
Date:	Tue, 19 Oct 2010 20:31:01 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Guenter Roeck <guenter.roeck@...csson.com>
Cc:	Ben Dooks <ben-linux@...ff.org>,
	Rodolfo Giometti <giometti@...ux.it>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] i2c/mux: Driver for PCA9541 I2C Master Selector

On Tue, 19 Oct 2010 11:08:05 -0700, Guenter Roeck wrote:
> On Tue, Oct 19, 2010 at 01:06:47PM -0400, Jean Delvare wrote:
> > On Tue, 12 Oct 2010 18:15:16 -0700, Guenter Roeck wrote:
> > > +     if (data->virt_adap == NULL) {
> > > +             dev_err(&client->dev,
> > > +                     "failed to register master selector as bus %d\n",
> > > +                     force);
> > 
> > This error message is somewhat confusing if "force" is 0: in that case
> > you didn't request any specific bus number.
>
> This is from pca954x code. Not sure how to rephrase it. Got an idea ?

Just "failed to register master selector\n" should do. The adapter
number doesn't really add any value.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/