[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20101019202447.GA10052@dumpdata.com>
Date: Tue, 19 Oct 2010 16:24:47 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To: stefano.stabellini@...citrix.com
Cc: xen-devel@...ts.xensource.com,
Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
linux-kernel@...r.kernel.org, Qing He <qing.he@...el.com>,
Yunhong Jiang <yunhong.jiang@...el.com>
Subject: Re: [Xen-devel] [PATCH v4 03/10] xen: remap MSIs into pirqs when
running as initial domain
> > + rc = HYPERVISOR_physdev_op(PHYSDEVOP_map_pirq, &map_irq);
> > + if (rc) {
> > + printk(KERN_WARNING "xen map irq failed %d\n", rc);
> > +
> > + dynamic_irq_cleanup(irq);
>
> Looking at include/linux/irq.h, I see this commment:
> /*
> 330 * Dynamic irq helper functions. Obsolete. Use irq_alloc_desc* and
> 331 * irq_free_desc instead.
> 332 */
>
> So we should use irq_free_desc instead of dynamic_irq_cleanup.
> (fyi, I didn't realize this until I started pulling in the sparse_irq
> patchset).
I looked at the rest of the patches and they all look good to me. Fix
this above and you can stick
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
on all the patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists