| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101019234929.3d4d14f4@endymion.delvare> Date: Tue, 19 Oct 2010 23:49:29 +0200 From: Jean Delvare <khali@...ux-fr.org> To: guenter.roeck@...csson.com Cc: Ben Dooks <ben-linux@...ff.org>, Rodolfo Giometti <giometti@...ux.it>, "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] i2c/mux: Driver for PCA9541 I2C Master Selector On Tue, 19 Oct 2010 13:50:53 -0700, Guenter Roeck wrote: > Hi Jean, > > On Tue, 2010-10-19 at 13:06 -0400, Jean Delvare wrote: > [ ... ] > > > + > > > +/* > > > + * I2C init/probing/exit functions > > > + */ > > > +static int __devinit pca9541_probe(struct i2c_client *client, > > > + const struct i2c_device_id *id) > > > > The use of __devinit and __devexit isn't recommended for i2c drivers. > > If your driver is built into the kernel but the underlying i2c bus > > driver is build as a module, you're in trouble. > > > I don't mind changing this, but ... the code is copied from pca954x.c, > which also uses __devinit and __devexit for the same functions. Wouldn't > that be a problem there as well ? Or am I missing something ? You're right, this should be fixed. I take patches ;) -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists