linux-kernel - Re: [PATCH] kernel: printk: Fix a coding style issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101019152008.f1223d24.akpm@linux-foundation.org>
Date:	Tue, 19 Oct 2010 15:20:08 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ralf Thielow <ralf.thielow@...glemail.com>
Cc:	jason.wessel@...driver.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: printk: Fix a coding style issue.

On Tue, 19 Oct 2010 20:19:01 +0200
Ralf Thielow <ralf.thielow@...glemail.com> wrote:

> Fixed a coding style issue of "do_syslog" in
> case of open or close the log.
> 
> Signed-off-by: Ralf Thielow <ralf.thielow@...glemail.com>
> ---
>  kernel/printk.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/printk.c b/kernel/printk.c
> index 8fe465a..3539744 100644
> --- a/kernel/printk.c
> +++ b/kernel/printk.c
> @@ -273,9 +273,8 @@ int do_syslog(int type, char __user *buf, int len, bool from_file)
>  		return error;
>  
>  	switch (type) {
> -	case SYSLOG_ACTION_CLOSE:	/* Close log */
> -		break;
>  	case SYSLOG_ACTION_OPEN:	/* Open log */
> +	case SYSLOG_ACTION_CLOSE:	/* Close log */
>  		break;
>  	case SYSLOG_ACTION_READ:	/* Read from log */
>  		error = -EINVAL;

I don't really think that the code needed fixing there?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/